Repository navigation
The I/O chain stops rooting a story at the IO wait rollup — the DataFileRead standout is the root, as lane 5's rule and PgTargetWaitTests require; dev goes green again (partial #3691, lane 11 residue) - #3729
Merged
Conversation
… — the IO rollup roots nothing (lane 5's rule, PgTargetWaitTests)
erikdarlingdata
enabled auto-merge (squash)
September 19, 2026 11:58
This was referenced Sep 19, 2026
erikdarlingdata
added a commit
that referenced
this pull request
Sep 19, 2026
… PRs across the #3653, #3542 and #3691 waves, #3704, #3710, #3712 and #3735, spliced once (#3751) Sixty-five PRs merged to dev since #3672 (the first splice) across two seats - the coordinator's #3653 brains-review residue lanes and the wave-2 worker's #3542 / #3691 PostgreSQL-target engine lanes - and by rule none touched this file; each returned its entry to a buffer. This is the one splice. Text-only; one file; nothing outside ## [Unreleased] and the definition block moves. [Unreleased] gains a ### Changed between ### Added and ### Fixed (Keep-a-Changelog order) for the nine entries whose subject is a designed behaviour that now behaves differently - routing (#3712 confidence chooses the channel), gating (#3692 tempdb persistence, #3734 blocking/LRQ gates, #3724 peak-and-mean), the wire shape (#3719 one error envelope), the review guard's drift arm (#3673), lineage metadata (#3723) and two grading changes (#3693, #3747). Twenty-two new capabilities append to ### Added (the sixteen PostgreSQL-target fact families and rungs, CONFIG_CHANGED, the recurrence label, the V134/V135 columns, the review traps file, the measurement census); thirty-two defects append to ### Fixed. Order within each section is ascending PR number, as #3672 did. Every entry is one line and verbatim from its buffer (trailing whitespace only). Four PR pairs fold into one entry as the buffers wrote them (#3738+#3746, #3683+#3686, #3681+#3685, #3726+#3729); #3695 carries three entries. #3673 has no issue and cites none, like the file's ninety-six other ref-less entries. Five definitions added ([#3691], [#3704], [#3710], [#3712], [#3735]) at the end of the [Unreleased] run, which stays one ascending run (3517..3735). No archive touched; the split was not run. tools/changelog/changelog_archive.py verify: all PASS (1,483 bold entries, floor 1,329; 1,363 distinct refs resolve; 1,372 definitions; CRLF throughout; 409,263 bytes under the ceiling). Client-hygiene grep over the file: zero hits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Headline mechanism. Removes the one edge #3726 (lane 11, merged at 11:30Z ahead of its CI) added from the
IOwait TYPE ROLLUP (PG_WAIT_IO) intoPG_IO_READ_LATENCY_MS. Lane 5's rule — a rollup roots nothing of its own, becausePgTargetScorer.Waits.csgrades one wait once and the rollup scores 0 whenever its named standout fired — is pinned byPgTargetWaitTests.TheWalWaits_LeadIntoTheWriteChain_AndDataFileRead_IntoTheMemoryChain_WhileTheRollupsStayOut(Assert.Empty(graph.GetAllEdges(Io))), and that pin is what #3726's ownbuild/Darling PostgreSQL testsruns failed on (1 of 11,174) after the merge had already landed. This is the fix that makes dev green again. Partial #3691 (lane 11 residue); do not close.What stays.
PG_WAIT_IO_DATAFILEREAD → PG_IO_READ_LATENCY_MS— the standout is the root, exactly as lane 5's memory chain rootsIO:DataFileRead → PG_BUFFER_CACHE_PRESSURE. The rollup still COUNTS as a corroborator on the latency fact's amplifiers (PgTargetScorer.Io.cs): that is a predicate reading a verdict, not a story edge, and the wait tests do not constrain it. The chain's doc comment now states the rule and why an edge from the rollup would be a second door into the same room.Tests.
PgTargetIoTests.TheIoChain_…now pinsGetAllEdges(PG_WAIT_IO)EMPTY where it asserted one active edge. Executed here through the net10.0 harness withPgTargetWaitTestsadded to the census set on top of current dev (1acd6062): 455 / 456 green, the one red the harness-csprojDocCommentHygieneartifact. The whole set also ran green with theDARLING_TEST_PGe2es on the branch this was cherry-picked from.Diff: 2 files, +11 −12 —
PerformanceMonitor.Analysis/PgTargetRelationshipGraph.Io.cs,Darling/Darling.Tests/PgTargetIoTests.cs. Nothing else.Which component(s) does this affect?
How was this tested?
Above; no production read.
Checklist
dotnet build -c Debug)PG_WAIT_*edge in the PostgreSQL graph)Partial for #3691 (lane 11 residue). CHANGELOG untouched.