Skip to content

The Aurora-only-surface census accounts for the wait-profile anomaly advice (#3542 lane 9 follow-up; dev red on f8874097) - #3690

Merged
erikdarlingdata merged 1 commit into
devfrom
fix/3542-lane9-aurora-census
Sep 19, 2026
Merged

erikdarlingdata merged 1 commit into
devfrom
fix/3542-lane9-aurora-census

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

What does this PR do?

Dev went red on f8874097 (#3689, lane 9) on exactly one Lite census: AuroraOnlySqlIsGatedTests.EveryFileNamingAnAuroraOnlySurface_IsAccountedFor — PerformanceMonitor.Analysis/PgTargetAdvice.Anomaly.cs names aurora_stat_system_waits and the roster had no entry deciding what that means for a self-hosted target.

It is the PROSE class: the ANOMALY_PG_WAIT_PROFILE advice block tells the operator which instrument the baselined wait rate came from — Aurora's aurora_stat_system_waits() deltas as stored in pg_wait_stats — because that anomaly exists only where the engine measured waits. Stock PostgreSQL's sampled waits get no anomaly baseline in v1 (#3689 states it), and the advice must not read as if they did. The advice reads facts, never the target; the dependency itself is PgWaitStatsCollector's GATED entry, and the detector that emits the fact baselines pg_wait_stats, which is empty off Aurora.

One roster entry, with that reasoning as its value — the census's contract is the sentence, not the count.

Which component(s) does this affect?

  • Lite Tests

How was this tested?

Lite.Tests builds (-p:EnableWindowsTargeting=true, 0 errors, the one pre-existing xUnit2000 warning). The census itself first executes in CI's Windows build job; the failing run listed exactly this one file, so the roster entry is the complete remedy.

Checklist

  • I have read the contributing guide
  • My code builds with zero warnings of its own
  • No hardcoded credentials or server names

…advice: PROSE - the block names aurora_stat_system_waits as the instrument the baselined rate came from; the dependency is PgWaitStatsCollector's GATED entry (#3542 lane 9 follow-up)
@erikdarlingdata
erikdarlingdata merged commit 829773d into dev Sep 19, 2026
6 of 7 checks passed
@erikdarlingdata
erikdarlingdata deleted the fix/3542-lane9-aurora-census branch September 19, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant