Repository navigation
The Aurora-only-surface census accounts for the wait-profile anomaly advice (#3542 lane 9 follow-up; dev red on f8874097) - #3690
Merged
Conversation
…advice: PROSE - the block names aurora_stat_system_waits as the instrument the baselined rate came from; the dependency is PgWaitStatsCollector's GATED entry (#3542 lane 9 follow-up)
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dev went red on
f8874097(#3689, lane 9) on exactly one Lite census:AuroraOnlySqlIsGatedTests.EveryFileNamingAnAuroraOnlySurface_IsAccountedFor—PerformanceMonitor.Analysis/PgTargetAdvice.Anomaly.csnamesaurora_stat_system_waitsand the roster had no entry deciding what that means for a self-hosted target.It is the PROSE class: the
ANOMALY_PG_WAIT_PROFILEadvice block tells the operator which instrument the baselined wait rate came from — Aurora'saurora_stat_system_waits()deltas as stored inpg_wait_stats— because that anomaly exists only where the engine measured waits. Stock PostgreSQL's sampled waits get no anomaly baseline in v1 (#3689 states it), and the advice must not read as if they did. The advice reads facts, never the target; the dependency itself isPgWaitStatsCollector's GATED entry, and the detector that emits the fact baselinespg_wait_stats, which is empty off Aurora.One roster entry, with that reasoning as its value — the census's contract is the sentence, not the count.
Which component(s) does this affect?
How was this tested?
Lite.Testsbuilds (-p:EnableWindowsTargeting=true, 0 errors, the one pre-existing xUnit2000 warning). The census itself first executes in CI's Windowsbuildjob; the failing run listed exactly this one file, so the roster entry is the complete remedy.Checklist