Finish CONTRIBUTING.md's data-type rule: rewrite the 33 abbreviated int sites and move UnabbreviatedTypes in scope #3087

CONTRIBUTING.md's Data types bullet states two independent properties — "lowercase, never abbreviated (integer not int, nvarchar(max) not nvarchar(MAX))". #3081 / #3085 enforced the case half and deliberately left the abbreviation half uncovered, on a stated remediation cost rather than on detectability. TsqlConventionGuardTests already carries the detector (AbbreviatedTypeUse) and the measurement (AbbreviatedTypeSites()); Findings just declines to emit the rule.

That was the right call for a change whose subject was the guard. It is a half-state now, and the guard says so in its own words: TheAbbreviationScopeNote_CountsTheSitesItClaims reds the moment the count moves, and its message names the follow-through — "move UnabbreviatedTypes from the Data types bullet's Uncovered side to its Covered side, emit it from Findings, and give it a hazard fixture."

This issue is that follow-through: rewrite the sites, then move the rule in scope.

The count, re-derived

Driven through the guard's own AbbreviatedTypeSites() — the same population, the same code view, and the same TypeNameClauseCollisions blanking the enforced checks read — rather than a fresh grep:

33 sites in 7 files. Agrees with the figure the scope note carries, and every site enumerates back to a distinct regex match, so the total is not covering for a collapsed key.

int is the only abbreviation present. dec for decimal and double precision for float are the others T-SQL accepts and neither appears — a bound on the figure, not on the rule.

Scope of the in-scope move

All of it, or the disposition map contradicts itself:

• UnabbreviatedTypes moves from the Data types bullet's Uncovered array to its Covered array.
• Findings emits it.
• It gets a hazard fixture in TheDetector_FlagsEveryCoveredRule_AndNoBenignForm, whose rule coverage is asserted at set equality against CoveredRules.
• Its fixture is deleted from TheUncoveredRules_AreViolatedByFixturesThisGuardDoesNotFlag, whose fixture set is asserted at set equality against UncoveredRules.
• The abbreviation-cost pin (TheAbbreviationScopeNote_CountsTheSitesItClaims) and the note text it parses are deleted — a cost pin for a cost nobody is paying any more is a pin that can only go stale.
• The split-pair assertion in TheDispositionMap_PartitionsTheBulletsContributingStates drops to { "Indentation" }, since Data types stops being split. That assertion names the split bullets rather than counting them, so it reds rather than drifting — which is the whole reason it is shaped that way.

Two things that need care rather than a sweep

1. Three of the seven files carry an sp_executesql PARAMETER DECLARATION, not a query body

PgPlanFetcher.cs and LocalDataService.QueryStats.cs both hold N'@h varbinary(64), @stmt_start int, @stmt_end int', and LocalDataService.FinOps.Recommendations.cs holds N'@c int OUTPUT' — the same class, and the scope note only named the first shape.

A parameter declaration is not a statement body, so "DECLARE @x integer is valid, therefore this is too" is an inference about a grammar position rather than a fact about it. Nothing in this repository executes that path, so no test here can settle it and a green build would mean nothing.

It wants a live parse check, and the check should not be run against a monitored production server.

2. Every edit is inside a query string that runs against monitored production servers

The compiler cannot see a typo in one, so the parity pins are the only thing between a bad edit and a shipped one. #3085 established that none of the nine sites it fixed was verbatim-pinned by a *CollectorDefinitionTests parity constant — but these are different files, and that conclusion should not be inherited. Establish it per file, and re-run the guard afterwards.

Acceptance

• 33 → 0, re-derived through AbbreviatedTypeSites() rather than asserted.
• The rule reads as Covered and reds by name on UnabbreviatedTypes when one of the rewritten sites is reverted. A rule moved to Covered that cannot fail is worse than one honestly left uncovered.
• The detector must not match int inside a longer token — integer, bigint, smallint, tinyint, int_col, sysint — and those belong in the benign fixture set, where a greedy or unanchored match reds.