Skip to content

MCP alert settings: cpu.mode vocabulary differs between apps (Lite enum names vs Darling strings) #1911

Description

@erikdarlingdata

Filed from the #1895 review-bot audit's flagged-but-not-filed remainder, per the deferrals-get-issues rule.

#1895 aligned the cross-app MCP alert-settings KEY names (count_threshold, alerts_enabled), but deliberately left cpu.mode: Darling emits a string vocabulary ("sql"), Lite serializes its CpuAlertMode enum (Total/SqlOnly). Aligning the key alone would have traded a key-level mismatch for a value-level one, so it needs a vocabulary decision first: pick one value set (Darling's lowercase strings are the older public surface), map the other app onto it, and note the breaking change for MCP clients in the CHANGELOG like #1895's renames did. Mechanical once the vocabulary is chosen.

🤖 Generated with Claude Code

Activity

  1. erikdarlingdata commented on Jul 31, 2026

    @erikdarlingdata
    OwnerAuthor

    Shipped in #1923: Lite now reports cpu.mode - an ADD, not a rename, since Lite never reported it at all. Darling's lowercase "sql"/"total" vocabulary wins because its update_alert_settings validates against exactly those literals. The cross-app pin reads Darling's source for the literals rather than asserting Lite's own constants, so it goes red the day Darling changes vocabulary instead of passing forever.

  2. added a commit that references this issue on Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions