Add Cassandra integration #588
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Cassandra integration for ann-benchmark - single replica case
swasik
reviewed
May 8, 2025
swasik
suggested changes
May 8, 2025
swasik
reviewed
May 8, 2025
swasik
suggested changes
May 16, 2025
swasik
suggested changes
May 19, 2025
| batch.clear() | ||
| if batch: | ||
| self.conn.execute(batch) | ||
|
|
There was a problem hiding this comment.
We miss a method to parse experiment parameters (query_args in the config file):
def set_query_arguments(self, params):
self._ef_search = params| "DOT": "DOT_PRODUCT", | ||
| } | ||
|
|
||
| hnsw_distance_type = self.DISTANCE_MAPPING.get(self.metric, "EUCLIDEAN") |
There was a problem hiding this comment.
self. is not needed here as DISTANCE_MAPPING is local variable
| def fit(self, X, batch_size=100): | ||
| self.vector_dim = X.shape[1] | ||
| self._create_table() | ||
|
|
There was a problem hiding this comment.
You have to call self._create_index() here as well.
swasik
reviewed
May 19, 2025
|
|
||
| insert_query = f"INSERT INTO {self.table_name} (id, embedding) VALUES (?, ?)" | ||
| prepared = self.conn.prepare(insert_query) | ||
| batch = BatchStatement() |
There was a problem hiding this comment.
Use BatchStatement(batch_type=BatchType.UNLOGGED) here - this will use unlogged batches which are faster (no need to write them to log which is not needed while using it just for benchmarking).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Cassandra integration for ann-benchmark - single replica case
Run this commands to test it:
pip3 install -r requirements.txt
python3 install.py --algorithm cassandra
python3 run.py --dataset glove-25-angular --algorithm cassandra