Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: intx & ethash as submodules rather than Hunter packages #941

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Mar 29, 2023

With this we don't need Hunter anymore in the Conan mode.

@yperbasis yperbasis marked this pull request as ready for review April 4, 2023 09:16
@yperbasis yperbasis changed the title intx & ethash as submodules rather than Hunter packages build: intx & ethash as submodules rather than Hunter packages Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #941 (4e32f57) into master (444170a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   68.09%   68.09%   -0.01%     
==========================================
  Files         218      218              
  Lines       17425    17425              
  Branches     2697     2697              
==========================================
- Hits        11866    11865       -1     
+ Misses       4494     4493       -1     
- Partials     1065     1067       +2     

see 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me provided everything builds fine.

@yperbasis yperbasis merged commit 6403c0d into master Apr 4, 2023
@yperbasis yperbasis deleted the hunter_and_conan branch April 4, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants