Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Withdrawals #822

Merged
merged 20 commits into from
Feb 7, 2023
Merged

[core] Withdrawals #822

merged 20 commits into from
Feb 7, 2023

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Dec 28, 2022

This PR implements to core part of EIP-4895: Beacon chain push withdrawals as operations. It does not implement necessary changes (if any) to the body downloader.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #822 (dd676d3) into master (b48e449) will increase coverage by 0.01%.
The diff coverage is 75.67%.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   66.97%   66.99%   +0.01%     
==========================================
  Files         237      239       +2     
  Lines       18080    18192     +112     
  Branches     2758     2785      +27     
==========================================
+ Hits        12109    12187      +78     
- Misses       4901     4928      +27     
- Partials     1070     1077       +7     
Impacted Files Coverage Δ
core/silkworm/consensus/engine.cpp 100.00% <ø> (+6.45%) ⬆️
core/silkworm/consensus/engine.hpp 100.00% <ø> (ø)
core/silkworm/consensus/pos/engine.hpp 100.00% <ø> (ø)
core/silkworm/types/block.hpp 0.00% <ø> (ø)
core/silkworm/types/withdrawal.hpp 0.00% <0.00%> (ø)
core/silkworm/types/block.cpp 82.66% <65.00%> (-4.96%) ⬇️
core/silkworm/types/withdrawal.cpp 76.19% <76.19%> (ø)
core/silkworm/consensus/base/engine.cpp 92.07% <88.00%> (-0.86%) ⬇️
core/silkworm/consensus/pos/engine.cpp 87.50% <90.00%> (-12.50%) ⬇️
core/silkworm/execution/processor.cpp 85.93% <100.00%> (+0.45%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yperbasis yperbasis added the shanghai The Shanghai protocol upgrade label Jan 17, 2023
@yperbasis yperbasis changed the title [WIP] Withdrawals [core] Withdrawals Feb 2, 2023
@yperbasis yperbasis marked this pull request as ready for review February 2, 2023 11:51
@canepat canepat merged commit df5efbe into master Feb 7, 2023
@canepat canepat deleted the withdrawal branch February 7, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shanghai The Shanghai protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants