Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop condition for STOP_BEFORE_STAGE #772

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

canepat
Copy link
Member

@canepat canepat commented Sep 27, 2022

No description provided.

@canepat canepat requested a review from mriccobene September 27, 2022 11:48
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #772 (67ba5a3) into master (53b8d75) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   74.95%   74.96%           
=======================================
  Files         196      196           
  Lines       14106    14106           
  Branches     2208     2208           
=======================================
+ Hits        10573    10574    +1     
- Misses       2598     2602    +4     
+ Partials      935      930    -5     
Impacted Files Coverage Δ
core/silkworm/consensus/base/engine.cpp 90.90% <0.00%> (-1.71%) ⬇️
node/silkworm/rpc/server/call.hpp 70.57% <0.00%> (-0.86%) ⬇️
core/silkworm/types/block.cpp 87.00% <0.00%> (ø)
core/silkworm/state/in_memory_state.cpp 91.66% <0.00%> (ø)
core/silkworm/execution/evm.cpp 93.84% <0.00%> (+0.24%) ⬆️
core/silkworm/trie/hash_builder.cpp 98.60% <0.00%> (+0.93%) ⬆️
core/silkworm/trie/vector_root.hpp 91.30% <0.00%> (+4.34%) ⬆️
node/silkworm/rpc/completion_end_point.cpp 95.34% <0.00%> (+4.65%) ⬆️
core/silkworm/consensus/pos/engine.cpp 83.33% <0.00%> (+16.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@canepat canepat merged commit 1b7348d into master Sep 27, 2022
@canepat canepat deleted the fix_stop_after_stage branch September 27, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants