Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader sync-loop integration #770

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Conversation

mriccobene
Copy link
Member

@mriccobene mriccobene commented Sep 23, 2022

Move downloader to sync-loop

@mriccobene mriccobene requested a review from canepat September 23, 2022 15:50
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #770 (122174a) into master (2465bba) will decrease coverage by 0.10%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   75.05%   74.94%   -0.11%     
==========================================
  Files         196      196              
  Lines       14092    14106      +14     
  Branches     2204     2208       +4     
==========================================
- Hits        10577    10572       -5     
- Misses       2593     2600       +7     
- Partials      922      934      +12     
Impacted Files Coverage Δ
node/silkworm/db/mdbx.hpp 75.00% <0.00%> (ø)
...de/silkworm/downloader/internals/body_sequence.cpp 78.76% <ø> (ø)
...silkworm/downloader/internals/grpc_sync_client.hpp 0.00% <ø> (ø)
node/silkworm/downloader/sentry_client.hpp 0.00% <ø> (ø)
...ode/silkworm/downloader/internals/header_chain.cpp 58.72% <31.25%> (-0.50%) ⬇️
core/silkworm/consensus/pos/engine.cpp 83.33% <0.00%> (-16.67%) ⬇️
node/silkworm/rpc/server/call.hpp 69.71% <0.00%> (-1.43%) ⬇️
node/silkworm/rpc/server/server_context_pool.cpp 60.97% <0.00%> (-0.82%) ⬇️
core/silkworm/state/in_memory_state.cpp 92.18% <0.00%> (-0.53%) ⬇️
core/silkworm/types/block.cpp 87.00% <0.00%> (-0.50%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mriccobene mriccobene marked this pull request as ready for review September 27, 2022 08:54
@canepat canepat merged commit 53b8d75 into master Sep 27, 2022
@canepat canepat deleted the downloader_syncloop_integration branch September 27, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants