sentry: eth protocol handshake #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
- Coverage 74.65% 74.60% -0.05%
==========================================
Files 210 210
Lines 15934 15939 +5
Branches 2498 2499 +1
==========================================
- Hits 11896 11892 -4
- Misses 2998 3005 +7
- Partials 1040 1042 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* sentry.proto HandShake * sentry.proto SetStatus * ForkId (EIP-2124) * Status message exchange and verification * coroutines startup refactoring * fix Sepolia distinct_fork_numbers * ServerContextPool helper constructor to init SentryImpl members with its contexts
canepat
approved these changes
Jan 3, 2023
| BlockNum head_block_num; | ||
| StatusMessage message; | ||
|
|
||
| static StatusData test_instance(); |
There was a problem hiding this comment.
This seems to be a leftover because its only usage here is indeed commented out.
In any case, even if needed for future work I would suggest to move this test_instance function directly to a dedicated test folder, e.g. something like silkworm/sentry/test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry.proto HandShake
sentry.proto SetStatus
ForkId (EIP-2124)
Status message exchange and verification
coroutines startup refactoring
fix Sepolia distinct_fork_numbers
ServerContextPool helper constructor to init SentryImpl members with its contexts