Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloader - Set gRPC max (incoming) message size to server default #742

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

mriccobene
Copy link
Member

This PR tries to solve issue #734

@mriccobene mriccobene changed the title Set gRPC max (incoming) message size to server default Downloader - Set gRPC max (incoming) message size to server default Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #742 (3b2d7b2) into master (4f2c788) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
- Coverage   76.25%   76.21%   -0.04%     
==========================================
  Files         190      190              
  Lines       13052    13052              
  Branches     2118     2118              
==========================================
- Hits         9953     9948       -5     
- Misses       2211     2213       +2     
- Partials      888      891       +3     
Impacted Files Coverage Δ
node/silkworm/rpc/completion_end_point.cpp 90.69% <0.00%> (-4.66%) ⬇️
core/silkworm/state/in_memory_state.cpp 92.18% <0.00%> (-0.53%) ⬇️
core/silkworm/trie/hash_builder.cpp 98.13% <0.00%> (-0.47%) ⬇️
core/silkworm/types/transaction.cpp 81.78% <0.00%> (-0.32%) ⬇️
core/silkworm/execution/evm.cpp 93.61% <0.00%> (-0.24%) ⬇️
node/silkworm/rpc/server/call.hpp 70.57% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mriccobene mriccobene merged commit 9004e9c into master Aug 31, 2022
@mriccobene mriccobene deleted the downloader_issue_734_fix branch August 31, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants