Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude gRPC server tests from sanitizer builds #648

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Exclude gRPC server tests from sanitizer builds #648

merged 5 commits into from
Apr 27, 2022

Conversation

canepat
Copy link
Member

@canepat canepat commented Apr 27, 2022 •
edited
Loading

This PR excludes the gRPC server tests from the sanitizer builds.

@codecov
Copy link

codecov bot commented Apr 27, 2022 •
edited
Loading

Codecov Report

Merging #648 (80ffb44) into master (ba9817f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   82.89%   82.91%   +0.01%     
==========================================
  Files         176      176              
  Lines       15254    15254              
==========================================
+ Hits        12645    12648       +3     
+ Misses       2609     2606       -3
Impacted Files Coverage Δ
core/silkworm/state/in_memory_state.cpp 96.58% <0.00%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9817f...80ffb44. Read the comment docs.

@canepat canepat changed the title Using grpc::Server::Shutdown w/o deadline Exclude gRPC-intensive tests from sanitizer builds Apr 27, 2022
@canepat canepat changed the title Exclude gRPC-intensive tests from sanitizer builds Exclude gRPC server tests from sanitizer builds Apr 27, 2022
@canepat canepat requested a review from mriccobene April 27, 2022 16:57
@canepat canepat marked this pull request as ready for review April 27, 2022 16:57
@canepat canepat merged commit b952294 into master Apr 27, 2022
@canepat canepat deleted the backendkv_shutdown_nodeadline branch April 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccobene mriccobene mriccobene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canepat @mriccobene