Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max cursors per txn check in KV Tx RPC #645

Merged
merged 7 commits into from
Apr 27, 2022
Merged

Add max cursors per txn check in KV Tx RPC #645

merged 7 commits into from
Apr 27, 2022

Conversation

canepat
Copy link
Member

@canepat canepat commented Apr 22, 2022

This PR introduces a sanity check on max number of opened cursors per txn in KV Tx RPC.

Add check on cursor ID already in use
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #645 (e5eeccf) into master (536cde7) will increase coverage by 0.30%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   82.53%   82.84%   +0.30%     
==========================================
  Files         176      176              
  Lines       15239    15257      +18     
==========================================
+ Hits        12578    12639      +61     
+ Misses       2661     2618      -43     
Impacted Files Coverage Δ
node/silkworm/rpc/kv_calls.cpp 94.87% <75.00%> (+7.48%) ⬆️
core/silkworm/execution/evm.cpp 95.27% <0.00%> (-0.83%) ⬇️
core/silkworm/trie/hash_builder.cpp 99.29% <0.00%> (-0.71%) ⬇️
core/silkworm/state/intra_block_state.cpp 97.46% <0.00%> (+0.94%) ⬆️
node/silkworm/rpc/server_config.cpp 100.00% <0.00%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536cde7...e5eeccf. Read the comment docs.

@canepat canepat requested a review from mriccobene April 22, 2022 07:53
@canepat canepat marked this pull request as ready for review April 22, 2022 07:53
Remove unneeded check on cursor ID wrapping
@canepat canepat changed the title Add checks on KV Tx RPC Add max cursor per txn check in KV Tx RPC Apr 22, 2022
@canepat canepat changed the title Add max cursor per txn check in KV Tx RPC Add max cursors per txn check in KV Tx RPC Apr 22, 2022
@canepat canepat merged commit ba9817f into master Apr 27, 2022
@canepat canepat deleted the kv_tx_checks branch April 27, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants