Clear from field from given transaction when reading them from the DB #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
==========================================
- Coverage 82.52% 82.51% -0.02%
==========================================
Files 176 176
Lines 15237 15239 +2
==========================================
Hits 12574 12574
- Misses 2663 2665 +2
Continue to review full report at Codecov.
|
AndreaLanfranchi
suggested changes
Apr 21, 2022
node/silkworm/db/access_layer.cpp
Outdated
Comment on lines
190
to
191
| transaction.from.reset(); // rlp decode is not touching this field, so make sure it is empty | ||
| rlp::success_or_throw(rlp::decode(data_view, transaction)); |
There was a problem hiding this comment.
I find a more natural place to reset the from field in rlp::decode.
That way we can be sure data initialization is complete and atomic instead of having to remember we may/may not need to reset.
There was a problem hiding this comment.
You are right, changed it
AndreaLanfranchi
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.