Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test causing gRPC data race in sanitizer build #642

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

canepat
Copy link
Member

@canepat canepat commented Apr 20, 2022

This PR skips one specific test in TSAN build because such test triggers some data race within the gRPC library in a very specific scenario.

The "BackEndKvServer E2E: trigger server-side write error" test is purposely written to cause write-errors on Tx RPC server-side implementation by using the bidirectional-streaming API in an unorthodox way, i.e. not reading responses after sending requests and making the Tx call end abruptly on client-side by grpc::ClientContext destruction.

Repeating this pattern many times triggers write-errors on Tx RPC server-side implementation and allows to check that server-side lifecycle management for Tx calls is OK but seems to result also in a frequent data race detection during sanitizer builds.

@canepat canepat marked this pull request as ready for review April 20, 2022 16:48
@canepat canepat requested a review from mriccobene April 20, 2022 16:48
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #642 (13d7901) into master (a992e85) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   82.52%   82.47%   -0.06%     
==========================================
  Files         176      176              
  Lines       15237    15237              
==========================================
- Hits        12574    12566       -8     
- Misses       2663     2671       +8     
Impacted Files Coverage Δ
core/silkworm/execution/evm.cpp 94.86% <0.00%> (-1.24%) ⬇️
core/silkworm/state/in_memory_state.cpp 94.14% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a992e85...13d7901. Read the comment docs.

Copy link
Member

@mriccobene mriccobene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@canepat canepat merged commit 536cde7 into master Apr 21, 2022
@canepat canepat deleted the exclude_test_from_sanitizer_build branch April 21, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants