Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forward reference overload in KV RPC #640

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

canepat
Copy link
Member

@canepat canepat commented Apr 20, 2022

This PR removes the BidirectionalStreamingRpc::send_response method overload using forward reference because this is the one change causing repeated failures on TSAN CI job, namely here and here.

@canepat canepat requested a review from mriccobene April 20, 2022 07:41
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #640 (ae91ef1) into master (f4f6759) will increase coverage by 0.04%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   82.36%   82.40%   +0.04%     
==========================================
  Files         173      173              
  Lines       14996    14996              
==========================================
+ Hits        12351    12357       +6     
+ Misses       2645     2639       -6     
Impacted Files Coverage Δ
node/silkworm/rpc/call.hpp 93.23% <ø> (ø)
node/silkworm/rpc/kv_calls.cpp 87.39% <88.23%> (ø)
core/silkworm/crypto/sha-256.c 51.74% <0.00%> (+0.49%) ⬆️
core/silkworm/execution/evm.cpp 96.09% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f6759...ae91ef1. Read the comment docs.

Copy link
Member

@mriccobene mriccobene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@canepat canepat merged commit ca923f6 into master Apr 20, 2022
@canepat canepat deleted the partial_undo_commit_3eb6503 branch April 20, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants