-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Body downloader structure #630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canepat
requested changes
Apr 15, 2022
canepat
approved these changes
Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes in the structure of the header downloader and adds the structure of the body downloader.
The following diagram depicts the overall architecture:

The old header downloader is splitted in two classes:
In the same manner the body downloader is divided in two classes:
Two classes have the responsibility to implement headers and body downloading algorithms: HeaderChain and BodySequence. They are members of BlockDownloader whose responsibility is to receive messages and process them. Incoming messages (from remote peers) carry informations to HeaderChain and BodySequence (for example: hash announcemens, headers, bodies, ...). Also outgoing messages request information to HeaderChain and BodySequence (for example: new header or bodies needed) and send it to remote peers. Internal messages are a way for the objects in different thread to communicate.
Threading model: