-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move precompiles into standalone library #628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 75.91% 75.39% -0.52%
==========================================
Files 189 183 -6
Lines 13447 12465 -982
Branches 2162 2081 -81
==========================================
- Hits 10208 9398 -810
+ Misses 2347 2186 -161
+ Partials 892 881 -11
Continue to review full report at Codecov.
|
Hi, I actually started playing with the C API today. I should be able to share some results maybe tomorrow. WIP: https://github.com/torquem-ch/silkpre/compare/capi. I try to separate core functionality from gas cost so this can be used without heap allocated buffer. The nice C++ API could be build on top of it with gas cost so this becomes hourglass pattern. Don't you have issue with diamond dependency of secp256k1? |
Silkworm depends on silkpre, which in turns depends on secp256k1, so no diamond dependency. I've removed secp256k1 submodule from Silkworm. |
Move precompiles into a standalone library https://github.com/torquem-ch/silkpre. That library has a C API.
Paweł wrote a suggestion on the C API for Ethereum precompile libraries. Currently the API of torquem-ch/silkpre is somewhat different, but later we can converge to the proposed API.