Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor settings and services in BackEnd KV server #623

Merged
merged 11 commits into from
Mar 31, 2022
Merged

Refactor settings and services in BackEnd KV server #623

merged 11 commits into from
Mar 31, 2022

Conversation

canepat
Copy link
Member

@canepat canepat commented Mar 28, 2022 •
edited
Loading

This PR introduces small but relevant improvements in BackEnd KV standalone server, namely:

  • command-line options for backend_kv_server are compliant with silkworm node
  • new etherbase setting is added to silkworm::NodeSettings
  • refine KV Version RPC implementatation
  • renaming and refactoring in BackEnd & KV service structure

TODOLIST:

  • introduce validator checks for command-line options
  • refactor rpc::ServerConfig as rpc::ServerSettings struct with public fields like other settings

@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #623 (42e1fab) into master (d2060eb) will increase coverage by 0.04%.
The diff coverage is 84.28%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   82.07%   82.12%   +0.04%     
==========================================
  Files         174      173       -1     
  Lines       14399    14438      +39     
==========================================
+ Hits        11818    11857      +39     
  Misses       2581     2581
Impacted Files Coverage Δ
node/silkworm/rpc/server_context_pool.hpp 83.33% <ø> (+33.33%) ⬆️
node/silkworm/rpc/util.hpp 100.00% <ø> (ø)
node/silkworm/rpc/kv_calls.cpp 88.65% <65.62%> (ø)
node/silkworm/backend/ethereum_backend.cpp 100.00% <100.00%> (ø)
node/silkworm/backend/ethereum_backend.hpp 100.00% <100.00%> (ø)
node/silkworm/rpc/backend_calls.cpp 100.00% <100.00%> (ø)
node/silkworm/rpc/backend_kv_server.cpp 100.00% <100.00%> (ø)
node/silkworm/rpc/server_context_pool.cpp 93.87% <100.00%> (+6.12%) ⬆️
core/silkworm/trie/hash_builder.cpp 99.29% <0.00%> (-0.71%) ⬇️
core/silkworm/state/intra_block_state.cpp 97.46% <0.00%> (+0.94%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2060eb...42e1fab. Read the comment docs.

@canepat canepat force-pushed the backend_kv_server5 branch from 5f8aa6c to 5fa6335 Compare March 28, 2022 10:52
@canepat canepat marked this pull request as ready for review March 29, 2022 12:22
mriccobene
mriccobene approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@mriccobene mriccobene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yperbasis yperbasis merged commit 5de7d92 into master Mar 31, 2022
@yperbasis yperbasis deleted the backend_kv_server5 branch March 31, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccobene mriccobene mriccobene approved these changes

@AndreaLanfranchi AndreaLanfranchi Awaiting requested review from AndreaLanfranchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canepat @mriccobene @yperbasis