Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mergeForkBlock #614

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Add mergeForkBlock #614

merged 10 commits into from
Mar 18, 2022

Conversation

enriavil1
Copy link
Contributor

@enriavil1 enriavil1 commented Mar 15, 2022

mergeForkBlock corresponds to FORK_NEXT_VALUE of EIP-3675.

@enriavil1 enriavil1 requested a review from Giulio2002 March 15, 2022 15:39
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #614 (a3fac49) into master (dcb3e91) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   81.65%   81.64%   -0.01%     
==========================================
  Files         167      167              
  Lines       13925    13928       +3     
==========================================
+ Hits        11370    11372       +2     
- Misses       2555     2556       +1     
Impacted Files Coverage Δ
core/silkworm/chain/config.hpp 100.00% <ø> (ø)
core/silkworm/chain/config.cpp 96.00% <100.00%> (+0.09%) ⬆️
core/silkworm/state/intra_block_state.cpp 96.51% <0.00%> (-0.95%) ⬇️
core/silkworm/crypto/sha-256.c 51.74% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb3e91...a3fac49. Read the comment docs.

@enriavil1 enriavil1 marked this pull request as ready for review March 15, 2022 16:05
@yperbasis
Copy link
Member

Silkworm uses uint64 for block numbers. Why do you want to change it to uint256?

@enriavil1
Copy link
Contributor Author

Silkworm uses uint64 for block numbers. Why do you want to change it to uint256?

To match Erigon using big int in terminalBlockNumber

@AndreaLanfranchi
Copy link
Contributor

AndreaLanfranchi commented Mar 15, 2022

Silkworm uses uint64 for block numbers. Why do you want to change it to uint256?

To match Erigon using big int in terminalBlockNumber

And why Erigon uses such a huge var type ?
Isn't uint64 enough ? IMHO even a uint32 is more than abundant

@yperbasis yperbasis changed the title Terminal block num change to uint256 Add mergeForkBlock Mar 16, 2022
@enriavil1 enriavil1 requested review from yperbasis and canepat March 18, 2022 14:29
@yperbasis yperbasis merged commit 01158d7 into master Mar 18, 2022
@yperbasis yperbasis deleted the terminal_block_num-change branch March 18, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants