Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse cursors - 2 #612

Merged
merged 7 commits into from
Mar 11, 2022
Merged

Reuse cursors - 2 #612

merged 7 commits into from
Mar 11, 2022

Conversation

AndreaLanfranchi
Copy link
Contributor

  • Upgrade libmdbx to latest master so we include changes solving issue from reuse of cursors bound to RO transactions
  • Added more cursor pool tests
  • make db::Cursor constructible/bindable from RWTxn too

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #612 (fcc1caa) into master (5f079ca) will decrease coverage by 0.02%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   81.75%   81.73%   -0.03%     
==========================================
  Files         167      167              
  Lines       13947    13966      +19     
==========================================
+ Hits        11403    11415      +12     
- Misses       2544     2551       +7     
Impacted Files Coverage Δ
node/silkworm/db/mdbx.hpp 85.29% <0.00%> (-5.34%) ⬇️
node/silkworm/db/stages.cpp 88.88% <71.42%> (-7.89%) ⬇️
node/silkworm/db/mdbx.cpp 82.27% <75.00%> (-0.34%) ⬇️
core/silkworm/state/intra_block_state.cpp 97.46% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f079ca...fcc1caa. Read the comment docs.

@AndreaLanfranchi AndreaLanfranchi merged commit 9950241 into master Mar 11, 2022
@AndreaLanfranchi AndreaLanfranchi deleted the al-20220310 branch March 11, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants