Add KV RPC services #610
Merged
Add KV RPC services #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Server to handle many async services Add structure for KV RPC services Add KV RPC empty implementations Refactor ServerContextPool to separate start from join
Regenerate gRPC headers and sources Patch KV generated header for Protobuf DELETE issue Log gRPC version in BackEndKv standalone server
Regenerate gRPC headers and sources
Capture gRPC logging in BackEndKv standalone server Register all first RPC requests on the same context [WIP] Track total server-side RPC instances Add peer tracing in server-side RPC services Fix bidirectional streaming call state machine Improve gRPC log messages
Remove temporary hack from CMake file
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 81.75% 81.90% +0.14%
==========================================
Files 167 170 +3
Lines 13947 14215 +268
==========================================
+ Hits 11403 11643 +240
- Misses 2544 2572 +28
Continue to review full report at Codecov.
|
Add unit tests
Add check on sanitizer build for gRPC ASAN/TSAN Simplify CompletionRunner unit test
mriccobene
reviewed
Mar 17, 2022
|
Yes, you're right. Considering that the Service classes act mainly as factories of RPC calls, I'm going to rename |
Register all first RPC requests on all server contexts Fix data race in BackEnd KV test client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bidirectional-streaming RPC support
Refactor RPC Server to handle many async services
Add structure for KV RPC services
Add KV RPC empty implementations
Refactor ServerContextPool to separate start from join