Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable consensus tests under thread sanitizer #607

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Enable consensus tests under thread sanitizer #607

merged 6 commits into from
Mar 8, 2022

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Mar 8, 2022

Previously they were killed probably due to out of memory, so I reduced the number of threads to 4 (xlarge resource_class in CircleCI has 8 CPUs).

@yperbasis yperbasis linked an issue Mar 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #607 (dd8c6cd) into master (47b7a79) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head dd8c6cd differs from pull request most recent head d0a909c. Consider uploading reports for the commit d0a909c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   81.81%   81.74%   -0.07%     
==========================================
  Files         169      169              
  Lines       13949    13949              
==========================================
- Hits        11412    11403       -9     
- Misses       2537     2546       +9     
Impacted Files Coverage Δ
core/silkworm/state/intra_block_state.cpp 96.51% <0.00%> (-0.95%) ⬇️
core/silkworm/execution/evm.cpp 96.08% <0.00%> (-0.83%) ⬇️
core/silkworm/crypto/sha-256.c 51.24% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b7a79...d0a909c. Read the comment docs.

@yperbasis yperbasis merged commit 5b65bd5 into master Mar 8, 2022
@yperbasis yperbasis deleted the tsan branch March 8, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadSanitizer: consensus tests are killed
2 participants