Use .proto files from ledgerwatch/interfaces submodule #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 83.01% 83.08% +0.06%
==========================================
Files 150 150
Lines 11658 11658
==========================================
+ Hits 9678 9686 +8
+ Misses 1980 1972 -8
Continue to review full report at Codecov.
|
mriccobene
reviewed
Dec 14, 2021
There was a problem hiding this comment.
ok, but why did you choose erigon-lib and not https://github.com/ledgerwatch/interfaces ?
Right, I did not realize that interfaces has its own repo and is a subtree in erigon-lib. |
yperbasis
changed the title
mriccobene
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the .proto files copied to
silkworm/interfaces. Rationale: consistency.