Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20 & gcc 11 compatibility #502

Merged
merged 11 commits into from
Nov 19, 2021
Merged

C++20 & gcc 11 compatibility #502

merged 11 commits into from
Nov 19, 2021

Conversation

yperbasis
Copy link
Member

@yperbasis yperbasis commented Nov 18, 2021

Make Silkworm compatible with gcc 11 & C++20 (C++17 is still the default).

@yperbasis yperbasis linked an issue Nov 18, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #502 (fafe981) into master (b454586) will decrease coverage by 0.00%.
The diff coverage is 78.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   83.30%   83.29%   -0.01%     
==========================================
  Files         149      149              
  Lines       11466    11467       +1     
==========================================
  Hits         9552     9552              
- Misses       1914     1915       +1     
Impacted Files Coverage Δ
core/silkworm/common/util.hpp 100.00% <ø> (ø)
...de/silkworm/downloader/internals/working_chain.cpp 64.62% <72.97%> (+0.55%) ⬆️
core/silkworm/common/util.cpp 99.51% <100.00%> (ø)
node/silkworm/db/genesis.cpp 86.91% <100.00%> (ø)
...ode/silkworm/stagedsync/recovery/recovery_farm.cpp 64.03% <100.00%> (-0.08%) ⬇️
core/silkworm/consensus/base/engine.cpp 95.38% <0.00%> (-1.03%) ⬇️
core/silkworm/state/in_memory_state.cpp 91.51% <0.00%> (-0.90%) ⬇️
core/silkworm/trie/hash_builder.cpp 99.29% <0.00%> (-0.71%) ⬇️
core/silkworm/crypto/ecdsa.cpp 97.59% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b454586...fafe981. Read the comment docs.

Copy link
Member

@canepat canepat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe it could be worth it naming the CMake files more explicitly, i.e. rename toolchain.cmake as cpp17.cmake and move common settings in a generic toolchain.cmake included by both cpp17.cmake and cpp20.cmake. So that also CI configurations can be made more precise and intuitive

@yperbasis yperbasis merged commit 3843a8e into master Nov 19, 2021
@yperbasis yperbasis deleted the cpp20 branch November 19, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++20 mode in CI
2 participants