-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++20 & gcc 11 compatibility #502
Conversation
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 83.30% 83.29% -0.01%
==========================================
Files 149 149
Lines 11466 11467 +1
==========================================
Hits 9552 9552
- Misses 1914 1915 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe it could be worth it naming the CMake files more explicitly, i.e. rename toolchain.cmake
as cpp17.cmake
and move common settings in a generic toolchain.cmake
included by both cpp17.cmake
and cpp20.cmake
. So that also CI configurations can be made more precise and intuitive
Make Silkworm compatible with gcc 11 & C++20 (C++17 is still the default).