Avoid mutex in ExecutionStatePool for Wasm compatibility #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| std::unique_ptr<evmone::execution_state> ExecutionStatePool::acquire() noexcept { | ||
| std::lock_guard lock{mutex_}; | ||
| if (pool_.empty()) { | ||
| return std::make_unique<evmone::execution_state>(); | ||
| } |
There was a problem hiding this comment.
Not in this PR but why acquire from pool_ doesnt' use move semantic (like as in release method) ?
I mean this
std::unique_ptr<evmone::execution_state> obj{pool_.top().release()};
pool_.pop();
return obj;
could be changed to this
auto obj{std::move(pool_.top())};
pool_.pop();
return obj;
There was a problem hiding this comment.
Not in this PR but why acquire from pool_ doesnt' use move semantic (like as in release method) ?
I mean this
std::unique_ptr<evmone::execution_state> obj{pool_.top().release()}; pool_.pop(); return obj;could be changed to this
auto obj{std::move(pool_.top())}; pool_.pop(); return obj;
This should also probably work, I'm just not that familiar with move semantics.
AndreaLanfranchi
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #111