devnet: configuration fixes #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
changed the title
battlmonstr
force-pushed
the
pr/devnet_fix2
branch
from
e9058e7 to
1abead2
Compare
battlmonstr
force-pushed
the
pr/devnet_fix2
branch
7 times, most recently
from
9d45a3a to
ad3daab
Compare
The "dev" nodes need to have the same --miner.etherbase in order to generate the same genesis ExtraData by DeveloperGenesisBlock(). Override DevnetEtherbase global var that's used if --miner.etherbase is not passed. (for NonBlockProducer case)
* do not panic if SigKey is not found * save hardcoded DevnetEtherbase/DevnetSignPrivateKey into accounts so that SigKey can recover it
this avoids interface{} type casts and fixes an error with Heimdall.validatorSet == nil
* read the respBody fully using io.ReadAll before trying to decode it * unify sendHTTP and sendBatchHTTP
Problem:
If withTxs=false, the JSON response contains hash strings in "transactions",
and an attempt to Unmarshal to full jsonrpc.RPCTransaction objects fails with:
json: cannot unmarshal string into Go struct field body.transactions of type jsonrpc.RPCTransaction
Solution:
Unmarshal to a new struct - BlockWithTxHashes in this case.
This was referenced Oct 31, 2023
Closed
battlmonstr
force-pushed
the
pr/devnet_fix2
branch
from
ad3daab to
f555884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "genesis hash does not match" when dev nodes connect
The "dev" nodes need to have the same --miner.etherbase in order to generate the same genesis ExtraData by DeveloperGenesisBlock(). Override DevnetEtherbase global var that's used if --miner.etherbase is not passed. (for NonBlockProducer case)
fix missing private key for the hardcoded DevnetEtherbase
Fixes panic if SigKey is not found. Bor non-producers will use a default
DevnetEtherbasewhile Dev nodes modify it. Save hardcoded DevnetEtherbase/DevnetSignPrivateKey into accounts so that SigKey can recover it.refactor devnet.node to contain Node config
This avoids interface{} type casts and fixes an error with Heimdall.validatorSet == nil
add connection retries to rpcCall and Subscribe of requestGenerator
Fixes "connection refused" errors due to node not ready to handle early RPC requests.
fix deadlock in Heimdall.NodeStarted
fix GetBlockByNumber
Fixes "cannot unmarshal string into Go struct field body.transactions of type jsonrpc.RPCTransaction"
demote "no of blocks on childchain is less than confirmations required" to Info (devnet test error: L2 header processing - childchain has less confirmations than required #8626)
demote "mismatched pending subpool size" to Debug (devnet test failure: mismatched pending subpool size expected=0 got=1 #8615)
revert wiggle testing code