blockValue should use gasUsed rather than gasLimit #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexoscott
approved these changes
Feb 14, 2023
turbo/builder/block_builder.go
Outdated
|
|
||
| // BlockBuilder wraps a goroutine that builds Proof-of-Stake payloads (PoS "mining") | ||
| type BlockBuilder struct { | ||
| interrupt int32 | ||
| syncCond *sync.Cond | ||
| block *types.Block | ||
| block *types.BlockWithReceipts |
There was a problem hiding this comment.
maybe an updated name here? calls like b.block.Block could get confusing.
finiteops
pushed a commit
to bitfinity-network/erigon
that referenced
this pull request
Apr 10, 2023
Fees going to the gas fee recipient should be based on the actual gas used (available in the receipt) rather than the gas limit in a transaction. This fixes Hive test "GetPayloadV2 Block Value". Also `engine_getPayloadBodiesByRangeV1` params should be encoded as hex strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fees going to the gas fee recipient should be based on the actual gas used (available in the receipt) rather than the gas limit in a transaction. This fixes Hive test "GetPayloadV2 Block Value".
Also
engine_getPayloadBodiesByRangeV1params should be encoded as hex strings.