use a shared simulated tx when mining #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Dec 9, 2022
|
(Nitpicking) pls run |
hexoscott
force-pushed
the
mining-fixes
branch
from
3ff1620 to
713a060
Compare
|
go mod tidy run now after updating to latest erigon-lib to get YieldBest function across. |
yperbasis
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the filter bad transactions can use the same context each time, so increases an account nonce in the first batch of transactions is committed to the simulation just in case the same account appears in the next batch of transactions.
Also makes use of the new txpool candidate functionality to ensure we're getting fresh transactions each time.