Fix trace error in Polygon | Pass Engin to the Base API #6131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
commented
Nov 25, 2022
Comment on lines
+31
to
+33
| // TODO: Replace with correct consensus Engine | ||
| engine := ethash.NewFaker() | ||
| apiList := commands.APIList(db, borDb, backend, txPool, mining, ff, stateCache, blockReader, agg, *cfg, engine) |
There was a problem hiding this comment.
This would need to be modified in theory, but I wasn't quite sure whether it was worth the extra work (we need extra arguments about Heimdall RPC for Polygon, etc.)
AskAlexSharov
requested changes
Nov 25, 2022
I looked a bit at some of the consensus and saw some locks, so I thought it was safe. Looking a bit more carefully, it wasn't actually always the case. Thus, I reduced the |
AskAlexSharov
approved these changes
Nov 25, 2022
|
@ngotchac merge devel plz |
ngotchac
force-pushed
the
ngotchac/api-pass-engine
branch
from
fd54538 to
898f8f1
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there is an issue with tracing certain blocks/transactions on Polygon, for example:
gives the error
first run for txIndex 1 error: insufficient funds for gas * price + value: address 0x10AD27A96CDBffC90ab3b83bF695911426A69f5E have 16927727762862809 want 17594166808296934The reason is that this transaction is from the author of the block, which doesn't have enough ETH to pay for the gas fee + tx value if he's not the block author receiving transactions fees.
The issue is that currently the APIs are using
ethash.NewFaker()Engine for running traces, etc. which doesn't know how to get the author for a specific block (which is consensus dependant); as it was noting in several TODO comments.The fix is to pass the Engine to the BaseAPI, which can then be used to create the right Block Context. I chose to split the current Engine interface in 2, with Reader and Writer, so that the BaseAPI only receives the Reader one, which might be safer (even though it's only used for getting the block Author).