Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix debug_storageRangeAt #3148

Merged
merged 2 commits into from
Dec 29, 2021
Merged

fix debug_storageRangeAt #3148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521c1f2
fix debug_storageRangeAt
bgelb Dec 19, 2021
63786c6
fix missing ()
bgelb Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions turbo/transactions/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ func ComputeTxEnv(ctx context.Context, block *types.Block, cfg *params.ChainConf
// Ensure any modifications are committed to the state
// Only delete empty objects if EIP158/161 (a.k.a Spurious Dragon) is in effect
_ = statedb.FinalizeTx(vmenv.ChainRules(), reader)

if idx+1 == len(block.Transactions()) {
// Return the state from evaluating all txs in the block, note no msg or TxContext in this case
return nil, BlockContext, vm.TxContext{}, statedb, reader, nil
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doing same? https://github.com/ledgerwatch/erigon/pull/3148/files#diff-664a6f9734f5a173f4805bd1eee6763dab47fff1aec9839fdbef67036d7b09faR58

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I did not quite understand this comment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

}
return nil, vm.BlockContext{}, vm.TxContext{}, nil, nil, fmt.Errorf("transaction index %d out of range for block %x", txIndex, blockHash)
}
Expand Down