Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EIP-4399] Remove newly added Header.Random (reuse mixHash instead) #3069

Merged
merged 3 commits into from
Dec 1, 2021
Merged

[EIP-4399] Remove newly added Header.Random (reuse mixHash instead) #3069

merged 3 commits into from
Dec 1, 2021

Conversation

yperbasis
Copy link
Member

No description provided.

@yperbasis yperbasis requested a review from Giulio2002 December 1, 2021 08:55
Giulio2002
Giulio2002 reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@Giulio2002 Giulio2002 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, other than my previous thought, which i think it is unlikely to have any basis of truth, this PR can go, given CI passes

eth/stagedsync/stage_difficulty.go Show resolved Hide resolved
@Giulio2002
Copy link
Contributor

BTW, the fail happens due to the fact that mockPayloadHashes do not match anymore with the payload, you need to update those, i am pretty sure about it

@yperbasis yperbasis marked this pull request as draft December 1, 2021 09:42
@yperbasis yperbasis marked this pull request as ready for review December 1, 2021 12:02
@yperbasis yperbasis merged commit 094ab5e into devel Dec 1, 2021
@yperbasis yperbasis deleted the remove_random branch December 1, 2021 12:41
@yperbasis yperbasis mentioned this pull request Dec 2, 2021
Closed
12 tasks
@VBulikov VBulikov mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giulio2002 Giulio2002 Giulio2002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @Giulio2002