Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: 1559 in call and tracing #2327

Merged
merged 7 commits into from
Jul 11, 2021
Merged

Conversation

AskAlexSharov
Copy link
Collaborator

No description provided.

@perama-v
Copy link

I did some testing at commit hash 243f66d looking at RPC calls to trace_transaction at the fork block 5062605 for Goerli. I'm not sure if this is useful for this particular PR, so please ignore if it is unrelated.

Using, TrueBlocks I called chifra blocks -t 5062605 to get all the transactions in the fork block with -t to get traces. With verbose logging in TruBlocks, I exposed the following RPC errors:

curl -s --data '{"method":"trace_transaction","params":["0x0b08bbe52e24633c2c37ff8a76db9099b25b57d849ecc4816e5289508b0564d6"],"id":"1","jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST http://localhost:8545
result:
--["error":"code":-32000]--
--["message":"method handler crashed"]--

and

curl -s --data '{"method":"trace_transaction","params":["0x638cf1e54977513b75196127a9633080b23c108ef03645805fd97ac971ad9ea1"],"id":"1","jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST http://localhost:8545
result:
--["error":"code":-32000]--
--["message":"method handler crashed"]--

Calls to the blocks prior to the fork (chifra blocks -t 5062604 and earlier) seem to be passing, and calls at and after the fork all return method handler crashed (manual testing of ~20 blocks).

This behaviour is replicated on the devel branch. I tested on this branch with git fetch, then git switch 1559_rpc_call_and_tracing then make erigon and make rpcdaemon.

@AskAlexSharov
Copy link
Collaborator Author

@perama-v , thank you, it was related. Fixed in this branch.

@AskAlexSharov AskAlexSharov changed the title [to test] 1559 rpc call and tracing rpc: 1559 in call and tracing Jul 11, 2021
@AskAlexSharov AskAlexSharov merged commit 5eaf4c8 into devel Jul 11, 2021
@AskAlexSharov AskAlexSharov deleted the 1559_rpc_call_and_tracing branch July 11, 2021 04:05
@perama-v
Copy link

perama-v commented Jul 11, 2021

Great to hear. I pulled devel and ran the test again:

--------------------------------------------------
curl -s --data '{"method":"trace_transaction","params":["0x0b08bbe52e24633c2c37ff8a76db9099b25b57d849ecc4816e5289508b0564d6"],"id":"1","jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST http://localhost:8545
result:
--["error":"code":-32000]--
--["message":"first run for txIndex 0 error: fee cap less than block base fee: address 0xF19a20E7d221031c996f7E1a47Ed29D82108d2e4]--
--[feeCap: 0 baseFee: 1000000000"]--
earlyAbort: 0
curlID: 59
earlyAbort: 0
curlID: 61
--------------------------------------------------

This behaviour is slightly different now, but still occurs at and after the Goerli fork block, but not before.

@AskAlexSharov
Copy link
Collaborator Author

@perama-v , I tested your tx and it works on goerli. Please check that you re-build and re-started Erigon and Rpcdaemon

@perama-v
Copy link

My apologies, I neglected to make rpcdaemon. I have verified that the behaviour is normal around the fork block.

Sorry!

@AskAlexSharov
Copy link
Collaborator Author

@perama-v , very nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants