Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property tests for kv snapshot #1928

Merged
merged 8 commits into from
May 13, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
first failing test
  • Loading branch information
b00ris committed May 12, 2021
commit 9692f8e86453ecf9758f15f1eaeb127bf8393641
86 changes: 80 additions & 6 deletions ethdb/kv_snapshot_property_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
)

func TestGetAndPut(t *testing.T) {
t.SkipNow()
rapid.Check(t, rapid.Run(&getPutkvMachine{}))
}

Expand Down Expand Up @@ -252,16 +253,15 @@ func (m *getKVMachine) Get(t *rapid.T) {
}

func TestGet(t *testing.T) {
t.SkipNow()
rapid.Check(t, rapid.Run(&getKVMachine{}))
}



func TestCursorWithTX(t *testing.T) {
//t.SkipNow()
rapid.Check(t, rapid.Run(&cursorKVMachine{}))
}


type cursorKVMachine struct {
bucket string
snKV RwKV
Expand All @@ -270,8 +270,8 @@ type cursorKVMachine struct {
snTX RwTx
modelTX RwTx

snCursor RwCursor
modelCursor RwCursor
snCursor RwCursor
modelCursor RwCursor

snapshotKeys [][20]byte
newKeys [][20]byte
Expand All @@ -293,6 +293,10 @@ func (m *cursorKVMachine) Init(t *rapid.T) {
}).Draw(t, "generate not excisting keys").([][20]byte)
m.allKeys = append(m.snapshotKeys, notExistingKeys...)

defer func() {
m.snTX = nil
m.modelTX = nil
}()
txSn, err := m.snKV.BeginRw(context.Background())
require.NoError(t, err)
defer txSn.Rollback()
Expand Down Expand Up @@ -325,15 +329,16 @@ func (m *cursorKVMachine) Clean() {
if m.modelTX != nil {
m.modelTX.Rollback()
}

m.snKV.Close()
m.modelKV.Close()

}

func (m *cursorKVMachine) Begin(t *rapid.T) {
if m.modelTX != nil && m.snTX != nil {
return
}

mtx, err := m.modelKV.BeginRw(context.Background())
require.NoError(t, err)
sntx, err := m.snKV.BeginRw(context.Background())
Expand All @@ -350,6 +355,8 @@ func (m *cursorKVMachine) Rollback(t *rapid.T) {
m.modelTX.Rollback()
m.snTX = nil
m.modelTX = nil
m.snCursor = nil
m.modelCursor = nil
}

func (m *cursorKVMachine) Commit(t *rapid.T) {
Expand All @@ -362,6 +369,8 @@ func (m *cursorKVMachine) Commit(t *rapid.T) {
require.NoError(t, err)
m.snTX = nil
m.modelTX = nil
m.snCursor = nil
m.modelCursor = nil
}

func (m *cursorKVMachine) Cursor(t *rapid.T) {
Expand All @@ -387,4 +396,69 @@ func (m *cursorKVMachine) CloseCursor(t *rapid.T) {
}
m.modelCursor.Close()
m.snCursor.Close()
m.modelCursor = nil
m.snCursor = nil
}

func (m *cursorKVMachine) First(t *rapid.T) {
if m.modelCursor == nil && m.snCursor == nil {
return
}
k1, v1, err := m.modelCursor.First()
require.NoError(t, err)
k2, v2, err := m.snCursor.First()
require.NoError(t, err)
require.Equal(t, k1, k2)
require.Equal(t, v1, v2)
}

func (m *cursorKVMachine) Last(t *rapid.T) {
if m.modelCursor == nil && m.snCursor == nil {
return
}
k1, v1, err := m.modelCursor.Last()
require.NoError(t, err)
k2, v2, err := m.snCursor.Last()
require.NoError(t, err)
require.Equal(t, k1, k2)
require.Equal(t, v1, v2)
}

func (m *cursorKVMachine) Seek(t *rapid.T) {
if m.modelCursor == nil && m.snCursor == nil {
return
}
key := rapid.SampledFrom(m.allKeys).Draw(t, "get random key").([20]byte)
k1, v1, err := m.modelCursor.Seek(key[:])
require.NoError(t, err)
k2, v2, err := m.snCursor.Seek(key[:])
require.NoError(t, err)
require.Equal(t, k1, k2)
require.Equal(t, v1, v2)
}

func (m *cursorKVMachine) SeekExact(t *rapid.T) {
if m.modelCursor == nil && m.snCursor == nil {
return
}

key := rapid.SampledFrom(m.allKeys).Draw(t, "get random key").([20]byte)
k1, v1, err := m.modelCursor.SeekExact(key[:])
require.NoError(t, err)
k2, v2, err := m.snCursor.SeekExact(key[:])
require.NoError(t, err)
require.Equal(t, k1, k2)
require.Equal(t, v1, v2)
}

func (m *cursorKVMachine) SeekNext(t *rapid.T) {
if m.modelCursor == nil && m.snCursor == nil {
return
}
k1, v1, err := m.modelCursor.Next()
require.NoError(t, err)
k2, v2, err := m.snCursor.Next()
require.NoError(t, err)
require.Equal(t, k1, k2)
require.Equal(t, v1, v2)
}
2 changes: 1 addition & 1 deletion tests/testdata