kv: add HasPrefix to TemporalTx and SharedDomains #14739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratorio
requested review from
sudeepdino008,
somnathb1,
awskii,
yperbasis and
AskAlexSharov
AskAlexSharov
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a new
HasPrefix(domain, prefix) (firstKey []byte, ok bool, err error)api toTemporalGetterthis will be used later on to implement eip-7610
HasStoragecheck in the various StateReader implementations that we havein a subsequent PR I will also add an implementation for
HasPrefixfor the remote kvnote: the reason for
firstKeyreturn is that inReaderParallelV3we record the read list so that will be used there to record a touch of the first storage slot (this is a bit of a question mark - not sure if we have to do it or not yet - waiting for response from Alex - but either way the API is probably most useful like this)