Skip to content

dir improvements: move some stuff from params #14713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025
Merged

dir improvements: move some stuff from params #14713

merged 5 commits into from
Apr 23, 2025

Conversation

yperbasis
Copy link
Member

Part of #14554

@yperbasis yperbasis changed the title dir improvements: move some stuff from params dir improvements: move some stuff from params Apr 23, 2025
@yperbasis yperbasis marked this pull request as ready for review April 23, 2025 12:23
@yperbasis yperbasis enabled auto-merge (squash) April 23, 2025 12:24
@antonis19
Copy link
Member

What do you think about having all constants such as configs, parameters etc. in the params package?

So instead of having libchain, params, and misc we just have params.

To me this makes imports way easier to remember.

@yperbasis
Copy link
Member Author

yperbasis commented Apr 23, 2025

What do you think about having all constants such as configs, parameters etc. in the params package?

So instead of having libchain, params, and misc we just have params.

To me this makes imports way easier to remember.

What I want to arrive to eventually is something like this – a set of cohesive and loosely coupled modules. Ideally the more foundational modules should know little or nothing about concrete blockchains (e.g. all Polygon-specific stuff should be inside the polygon module). From that viewpoint having all parameters sitting in one place is not desirable (e.g. I'd like to eventually move things like BorMainnetGenesisHash, etc to polygon instead of params/config.go.

@taratorio
Copy link
Member

What do you think about having all constants such as configs, parameters etc. in the params package?
So instead of having libchain, params, and misc we just have params.
To me this makes imports way easier to remember.

What I want to arrive to eventually is something like this – a set of cohesive and loosely coupled modules. Ideally the more foundational modules should know little or nothing about concrete blockchains (e.g. all Polygon-specific stuff should be inside the polygon module). From that viewpoint having all parameters sitting in one place is not desirable (e.g. I'd like to eventually move things like BorMainnetGenesisHash, etc to polygon instead of params/config.go.

that will be a great improvement! 🚀

@yperbasis yperbasis merged commit 5bf8905 into main Apr 23, 2025
12 checks passed
@yperbasis yperbasis deleted the dirs4 branch April 23, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants