Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve report messages in rules.go #14020

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve report messages in rules.go #14020

wants to merge 2 commits into from

Conversation

vipocenka
Copy link

@vipocenka vipocenka commented Feb 28, 2025 •
edited
Loading

  • Improved report messages:
    • Updated "maybe" phrasing to "Did you mean" for better readability.
    • Fixed wording in the rollback recommendation message for clarity and consistency.

@AskAlexSharov AskAlexSharov enabled auto-merge (squash) March 1, 2025 01:56
@AskAlexSharov
Copy link
Collaborator

@vipocenka what is it https://github.com/erigontech/erigon/actions/runs/13592822978/job/38023894384?pr=14020#step:4:26 ?

auto-merge was automatically disabled March 1, 2025 08:54

Head branch was pushed to by a user without write access

@vipocenka
Copy link
Author

@AskAlexSharov
I reverted the changes that were causing CI failures.
I will investigate the issue further and find a proper solution.

@vipocenka vipocenka changed the title Improve rule checks and report messages in rules.go Improve report messages in rules.go Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vipocenka @AskAlexSharov