engineeapi, txpool: Implement GetBlobsV1 #13975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
requested review from
taratorio,
shohamc1,
yperbasis,
Giulio2002 and
racytech
taratorio
reviewed
Mar 3, 2025
| "github.com/erigontech/erigon/core/types/testdata" | ||
| ) | ||
|
|
||
| func MakeBlobTxnRlp() ([]byte, []gokzg4844.KZGCommitment) { |
There was a problem hiding this comment.
if this is only used for testing, then a more intuitive place for it is typestest package
There was a problem hiding this comment.
I see you've renamed it to testdata, fine with me, but then MakeBlobTxn makes more sense to be part of it
taratorio
reviewed
Mar 3, 2025
| } | ||
| payloadSize := txw.payloadSize() | ||
| l := rlp.EncodeListPrefix(payloadSize, b[1:]) | ||
| w.Write(b[1 : 1+l]) |
There was a problem hiding this comment.
missing err handling here and line 406 below
taratorio
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on erigontech/interfaces#249