-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paratrie 2 #13958
Open
shotasilagadze
wants to merge
7
commits into
main
Choose a base branch
from
paratrie-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Paratrie 2 #13958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4258b75
to
6e27dd1
Compare
6e27dd1
to
3dbd3d8
Compare
3cd777c
to
0dd3712
Compare
AskAlexSharov
approved these changes
Mar 1, 2025
// we must submit the nibble updates and reinitialise slice | ||
if len(nibbleUpdates) != 0 { | ||
passedUpdates := append([]*nibbleUpdate{}, nibbleUpdates...) | ||
/* go */ phph.StartKeyProcessing(ctx, errChan, passedUpdates) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would advise: to run group of "similar" goroutines: use errgroup.WithContext
it will:
- cancel other goroutines if one failed
- don't need
errChan
- just returnerr
as any other golang code - can set max amount of simultaneous goroutines (to limit ram use, or if machine is small, etc...):
g.SetLimit(6)
(even if you always calc 16 prefixes in-parallel) - easier to understand when "work is done" and propagate error if need. by
if err := g.Wait(); err != nil { return err }
Only important limitation:
-
use 1
errgroup
for 1 set of similar goroutines. Example: If you have another goroutine for logging progress - don't add it toerrgroup
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.