-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polygon/heimdall: fix snapshot store RangeFromBlockNum #13689
Draft
taratorio
wants to merge
13
commits into
main
Choose a base branch
from
astrid-fix-range-from-block-num
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…range-from-block-num
…range-from-block-num
wait until #13702 is merged and issue with bor checkpoints snapshots generation is resolved (needs a bug fix and regeneration of snapshots) |
…range-from-block-num
…range-from-block-num
need to re-test once we fix snapshot generation logic for borcheckpoints and bormilestones to avoid gaps |
e.g. problem is in a gap like this (FirstInDb and LastInSnapshots should be connecting)
|
taratorio
added a commit
that referenced
this pull request
Feb 6, 2025
noticed while debugging #13689 also reported by a user on discord: [link](https://discord.com/channels/687972960811745322/983710221308416010/1334851818592927824)
…ange-from-block-num
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13674
issue was that after
rm -rf chaindata
:txEntityStore.EntityIdFromBlockNum
returns an entity id (in this case aCheckpoint
entity id) whose corresponding entity is no longer in the DB (in this caseerigon/datadir/heimdall/mdbx.dat
) because it has been retired into its corresponding snapshot filetxEntityStore.RangeFromBlockNum
returns only theCheckpoint
entities which it has in the DB (they are all with Start block num greater than the one in 1) - this creates a gap of X number of checkpointspos sync failed: block gap inserted
error which is because of the gap in checkpoints betweenstart
of downloading new blocks andstart
of first checkpoint in 2)Managed to reproduce the above by:
headers.seg
,bodies.seg
,transactions.seg
and corresponding.idx
filespos sync failed: unexpected first checkpoint with id 15274 has start 17673843 which is greater than download start 17660000
err check and hitting it after the above 2 steps