experimental: MPT block witness for Erigon 3 #12847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis19
requested review from
awskii,
AlexeyAkhunov,
AskAlexSharov and
mh0lt
|
@antonis19 do we need #12783 then? |
|
@awskii nope, just closed that PR. |
| return nil, err | ||
| } | ||
|
|
||
| var rejectedTxs []*RejectedTx | ||
| includedTxs := make(types.Transactions, 0, block.Transactions().Len()) | ||
| receipts := make(types.Receipts, 0, block.Transactions().Len()) | ||
| noop := state.NewNoopWriter() | ||
| // noop := state.NewNoopWriter() |
There was a problem hiding this comment.
this change seems not relevant
There was a problem hiding this comment.
It is relevant because we are injecting a custom StateWriter. I just left the comment as a reminder of what code was before.
awskii
requested changes
Dec 6, 2024
erigon-lib/kv/tables.go
Outdated
| @@ -455,7 +459,7 @@ var ChaindataTables = []string{ | |||
| ActiveValidatorIndicies, | |||
| EffectiveBalancesDump, | |||
| BalancesDump, | |||
|
|
|||
| // Witnesses, | |||
There was a problem hiding this comment.
table should be initialised? Please add to comment of witness when values in that bucket become obsolete or so. also could be good to add it to some cleanup lists (to have other that rm chaindata options to reset contents of this bcket
There was a problem hiding this comment.
The table is not used for now.
awskii
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental
eth_getWitnessRPC call implementation that computes the block witness for the MPT.This works roughly along the following lines:
This implementation is currently incomplete and still lacks support for the following cases which will be future work:
The code currently works correctly in 85% of the blocks of a small test chain of 161 blocks, for the unsupported cases mentioned above the RPC method will throw a root hash mismatch error.
I am proposing to merge the current PR even though the implementation is incomplete, so that we can incrementally add these features, and to avoid arduous merges or rebasing with main.