Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine API and type changes for flat requests in Pectra #12337

Merged
merged 20 commits into from
Oct 23, 2024
Merged

Engine API and type changes for flat requests in Pectra #12337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
163f729
Rename requestsRoot to requestsHash
somnathb1 Oct 18, 2024
bbfd5bb
Go mod tidy
somnathb1 Oct 18, 2024
793c6cb
Remove requests from body, block and exeution payload
somnathb1 Oct 18, 2024
b42189c
Lint
somnathb1 Oct 18, 2024
a29c2f1
Revert unnecessary
somnathb1 Oct 18, 2024
9f26d39
Remove reqs from stEnv
somnathb1 Oct 18, 2024
460a971
Add flat request hash and engine api sidecar
somnathb1 Oct 18, 2024
bcffdd5
Add exec spec tests back
somnathb1 Oct 18, 2024
22a297b
Change FlatRequests to slice rather than ptr
somnathb1 Oct 18, 2024
4969caf
Merge branch 'som/flat_requests' into som/pectra4_engine_api
somnathb1 Oct 18, 2024
8faeab7
Merge branch 'main' into som/remove_req_from_body
somnathb1 Oct 18, 2024
d374c62
Merge branch 'main' into som/rename_req_root
somnathb1 Oct 18, 2024
495debd
Merge branch 'som/rename_req_root' into som/remove_req_from_body
somnathb1 Oct 18, 2024
8c183cd
Merge branch 'som/remove_req_from_body' into som/pectra4_engine_api
somnathb1 Oct 18, 2024
1991a12
Modify Flat reqs a bit
somnathb1 Oct 20, 2024
8d6ea72
Remove rlp encoding methods from deposit req
somnathb1 Oct 20, 2024
c2fe612
Merge branch 'main' into som/remove_req_from_body
somnathb1 Oct 22, 2024
ff5581b
Merge branch 'som/remove_req_from_body' into som/pectra4_engine_api
somnathb1 Oct 22, 2024
2ceb3af
Remove depoist req RLP encode
somnathb1 Oct 22, 2024
43dfa5e
Merge branch 'main' into som/pectra4_engine_api
somnathb1 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove reqs from stEnv
  • Loading branch information
@somnathb1
somnathb1 committed Oct 18, 2024
commit 9f26d395f7c063782ee1ec0167d50c1325a4c28f
1 change: 0 additions & 1 deletion cmd/evm/internal/t8ntool/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ type stEnv struct {
UncleHash libcommon.Hash `json:"uncleHash,omitempty"`
Withdrawals []*types.Withdrawal `json:"withdrawals,omitempty"`
WithdrawalsHash *libcommon.Hash `json:"withdrawalsRoot,omitempty"`
Requests types.Requests `json:"requests,omitempty"`
RequestsHash *libcommon.Hash `json:"requestsHash,omitempty"`
}

Expand Down
6 changes: 0 additions & 6 deletions cmd/evm/internal/t8ntool/gen_stenv.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions cmd/evm/internal/t8ntool/transition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,6 @@ func Main(ctx *cli.Context) error {
return NewError(ErrorVMConfig, errors.New("shanghai config but missing 'withdrawals' in env section"))
}

if chainConfig.IsPrague(prestate.Env.Timestamp) && prestate.Env.Requests == nil {
return NewError(ErrorVMConfig, errors.New("prague config but missing 'requests' in env section"))
}

isMerged := chainConfig.TerminalTotalDifficulty != nil && chainConfig.TerminalTotalDifficulty.BitLen() == 0
env := prestate.Env
if isMerged {
Expand Down