Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug_accountRange(): increase block_number on storage walk (e2) #11669

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

lupin012
Copy link
Contributor

@lupin012 lupin012 commented Aug 19, 2024

I have done specific integration test(on e2) and compare the result with etherscan (block number 0x3D08FF: 3999999).
etherscan link:
https://etherscan.io/tx/0x535bd65cfee8655a1ffd8a28e065b47bcf557b10641491a541ab1dd08496709e#statechange
for account 0xEce701C76bD00D1C3f96410a0C69eA8Dfcf5f34E if use block_number + 1 the debug_accountRange() returns correctly for storage 0x0000000000000000000000000000000000000000000000000000000000000004 the new value: 0x000000000000000000000000000000000000000000000064a66fad67042ceb4a; using current software returns the old value (0x000000000000000000000000000000000000000000000064a3a922764918eb4b).
debug_accountRange() returns :
"storage": {
......
"0x0000000000000000000000000000000000000000000000000000000000000004": "64a66fad67042ceb4a",
----
}
If approved I will make change for e3

@lupin012 lupin012 changed the title fix: increase block_number on storage walk fix: debug_accountRange(): increase block_number on storage walk Aug 19, 2024
@lupin012 lupin012 marked this pull request as ready for review August 19, 2024 08:28
@lupin012 lupin012 changed the title fix: debug_accountRange(): increase block_number on storage walk fix: debug_accountRange(): increase block_number on storage walk (e2) Aug 19, 2024
AskAlexSharov pushed a commit that referenced this pull request Aug 20, 2024
@AskAlexSharov AskAlexSharov merged commit 3d7c090 into release/2.60 Aug 20, 2024
6 checks passed
@AskAlexSharov AskAlexSharov deleted the fix_blockNumber_on_dump_to_collector branch August 20, 2024 05:39
AskAlexSharov pushed a commit to stevemilk/erigon that referenced this pull request Aug 23, 2024
@yperbasis yperbasis added this to the v2.60.7-fixes milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants