Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune MaxTxNums table #11664

Merged
merged 24 commits into from
Aug 23, 2024
Merged

Prune MaxTxNums table #11664

merged 24 commits into from
Aug 23, 2024

Conversation

Giulio2002
Copy link
Contributor

@Giulio2002 Giulio2002 commented Aug 18, 2024

Main change is as follow that we can customize the seek in TxNumsReader now, so if you have a block reader you can inject it and use that instead than having the index in DB for antiquated snapshots. I did not implement live pruning for this yet as it is probably growing really slowly

@Giulio2002 Giulio2002 marked this pull request as draft August 18, 2024 16:58
@Giulio2002
Copy link
Contributor Author

@Giulio2002 Giulio2002 marked this pull request as ready for review August 19, 2024 22:47
@Giulio2002 Giulio2002 changed the title [Wip] Prune MaxTxNums table Prune MaxTxNums table Aug 19, 2024
@AskAlexSharov
Copy link
Collaborator

Need implement FindBlockNum method:

curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getLogs", "params": [ {"fromBlock":2500300, "toBlock":2500400}], "id":1}' http://localhost:8545
{"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"FindBlockNum(5001315): seems broken TxNum value: 0000000000000000 -\u003e (456d70, 0); last in db: (9099999, 30181416)"}}

@Giulio2002 Giulio2002 merged commit fef9086 into main Aug 23, 2024
10 checks passed
@Giulio2002 Giulio2002 deleted the prune-maxtxnums branch August 23, 2024 08:22
AskAlexSharov added a commit that referenced this pull request Aug 24, 2024
Main change is as follow that we can customize the seek in
`TxNumsReader` now, so if you have a block reader you can inject it and
use that instead than having the index in DB for antiquated snapshots. I
did not implement live pruning for this yet as it is probably growing
really slowly

---------

Co-authored-by: alex.sharov <AskAlexSharov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants