Add SQLitePCLRaw.bundle_green dependencies for .NET 6 #383
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#5366 In fixing test using `sqlite-net-pcl` in .NET 6 on Android, I found that `SQLitePCLRaw.bundle_green` is preferring the `netcoreapp3.1` dependencies over the `monoandroid8.0` ones. I could workaround the problem by adding a `<PackageReference/>`: <PackageReference Include="SQLitePCLRaw.lib.e_sqlite3.android" Version="2.0.4" /> Then at least some simple C# code that creates a table works in .NET 6 (on Android). If we add more target frameworks for `net6.0-android` and `net6.0-ios`, the existing Xamarin NuGet packages should pretty much work in .NET 6. This may not build at all, depending on the NuGet version being use here, but I thought this could at least get the conversation going. If you want to try out things in a real app, try: https://github.com/xamarin/net6-samples
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Dec 4, 2020
Fixes: #5319 Context: ericsink/SQLitePCL.raw#383 This test was originally failing in 6e3e383 with: android.runtime.JavaProxyThrowable: System.TypeInitializationException: The type initializer for 'SQLite.SQLiteConnection' threw an exception. ---> System.DllNotFoundException: e_sqlite3 at System.Runtime.InteropServices.NativeLibrary.LoadLibraryByName(String libraryName, Assembly assembly, Nullable`1 searchPath, Boolean throwOnError) at System.Runtime.InteropServices.NativeLibrary.Load(String libraryName, Assembly assembly, Nullable`1 searchPath) at SQLitePCL.NativeLibrary.Load(String libraryName, Assembly assy, Int32 flags) at SQLitePCL.Batteries_V2.MakeDynamic(String name, Int32 flags) at SQLitePCL.Batteries_V2.DoDynamic_cdecl(String name, Int32 flags) at SQLitePCL.Batteries_V2.Init() at SQLite.SQLiteConnection..cctor() The problem being one of the transitive dependencies of `sqlite-net-pcl`: [`SQLitePCLRaw.bundle_green`][0]. `SQLitePCLRaw.bundle_green` pulls in even more packages: .NETCoreApp 3.1 SQLitePCLRaw.core (>= 2.0.4) SQLitePCLRaw.lib.e_sqlite3 (>= 2.0.4) SQLitePCLRaw.provider.dynamic_cdecl (>= 2.0.4) MonoAndroid 8.0 SQLitePCLRaw.core (>= 2.0.4) SQLitePCLRaw.lib.e_sqlite3.android (>= 2.0.4) SQLitePCLRaw.provider.e_sqlite3 (>= 2.0.4) `SQLitePCLRaw.lib.e_sqlite3.android` contains the `libe_sqlite3.so` native library for Android. In .NET 6, NuGet is preferring the `.NETCoreApp 3.1` packages over the `MonoAndroid 8.0` ones. This means that the `MonoAndroid 8.0` package contents aren't included in the `.apk`, resulting in the `DllNotFoundException`. To manually workaround the problem we can add an explicit `@(PackageReference)` to [`SQLitePCLRaw.lib.e_sqlite3.android`][1] into the Android head project: <PackageReference Include="SQLitePCLRaw.lib.e_sqlite3.android" Version="2.0.4" /> Then the test works as expected. [Eventually, `SQLitePCLRaw.bundle_green` will need to include][2] dependencies for .NET 6, such as: net6.0-android SQLitePCLRaw.core (>= 2.0.4) SQLitePCLRaw.lib.e_sqlite3.android (>= 2.0.4) SQLitePCLRaw.provider.e_sqlite3 (>= 2.0.4) net6.0-ios SQLitePCLRaw.core (>= 2.0.4) SQLitePCLRaw.provider.dynamic_cdecl (>= 2.0.4) This will solve the problem for customers going forward. [0]: https://www.nuget.org/packages/SQLitePCLRaw.bundle_green/ [1]: https://www.nuget.org/packages/SQLitePCLRaw.lib.e_sqlite3.android/ [2]: ericsink/SQLitePCL.raw#383
Closed
|
Is this PR still "fresh" with respect to the .NET 6 previews that have happened since it was submitted? My goal is to finally do a 2.0.5 release sometime in August, and I want that release to be as ready as possible for .NET 6, keeping in mind that I still have Sep + Oct to do any further net6.0-specific fixes. |
|
The changes here seem valid, but you should probably test. There are behavior changes in NuGet in .NET 6 which might require you to specify I would try just installing .NET 6 and the Android workload. Then try Here is an example I had to workaround something with |
|
Closing this to clear out my list -- but let me know if you need assistance here, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5366
In fixing a test using
sqlite-net-pclin .NET 6 on Android, I foundthat
SQLitePCLRaw.bundle_greenis preferring thenetcoreapp3.1dependencies over the
monoandroid8.0ones.I could workaround the problem by adding a
<PackageReference/>:Then at least some simple C# code that creates a table works in .NET 6
(on Android). If we add more target frameworks for
net6.0-androidand
net6.0-ios, the existing Xamarin NuGet packages should prettymuch work in .NET 6.
This may not build at all, depending on the NuGet version being used
here, but I thought this could at least get the conversation going.
If you want to try out things in a real app, try:
https://github.com/xamarin/net6-samples
Let me know if you have other thoughts, thanks!