-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout/TrailingWhitespace on every single line #54
Comments
@brendonrapp Apologies for the delay on this one; I should have a resolution for you over the weekend at the latest. |
Reproduced, including for files with interpolated Ruby. @brendonrapp could you confirm your version of Ruby as well? |
(My guess is this is a weird interaction between Ruumba and a newer version of RuboCop, but it's always good to have more information.) Actually, if you could share your RuboCop version, that'd be helpful, too. |
In the meantime, I'll pin rubocop as > 1.5 in ruumba's Gemfile. |
Note that, as per the README, Layout/TrailingEmptyLines is expected (this cop needs to be disabled pending a future PR). |
@brendonrapp Apologies for the long delay here. My recommendation is to disable this cop pending a fix (which I'll get to as soon as I have some spare cycles). |
Since we extract the ruby code from inside the template and run rubocop on it, keeping the column positions (filling with whitespace) so that we can find where the code came from when auto correcting, most layout and style cops don't make much sense with ruumba. If we are not auto-correcting (which is experimental currently anyway), we can strip out the trailing spaces and the trailing newlines to avoid those violations. We will still get indention cop violations etc, but perhaps this at least gives a slightly better out of the box experience. Closes ericqweinstein#54
test.html.erb
Ruumba output:
The text was updated successfully, but these errors were encountered: