Fix of amd module definition #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnorris
added a commit
that referenced
this pull request
Feb 5, 2017
v3.0.0 incorrectly passed the striptags function to `define`, when it should have passed in a module factory that returns the striptags function. See #24.
|
Good catch, @morpheus-87! I had made a test to make sure that I did the AMD stuff properly, but I was testing it to the incorrect specification. I implemented your change and also updated the test to make sure it's Can you confirm it fixes the issue on your end? |
|
I can confirm, that your changes fix the issue. But why didn't you just merge my request? |
|
I first wrote a change to the test that verifies AMD is done properly. Considering it was a one line change to then fix the problem, I didn't see a particular need to spend time merging your request when I already had my editor open. Thanks again for reporting the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an error in the definition of the amd module.
When requiring the module with a module loader, e.g. RequireJS, the return value was always an empty string. The reason for this behaviour is, that the second argument of the
definefunction gets executed. So, in your way, the functionstriptagswas called without arguments and returned an empty string.