Skip to content

corrected code in ECDF function in utils.py #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2019
Merged

corrected code in ECDF function in utils.py #82

merged 1 commit into from
Dec 28, 2019

Conversation

pydatawrangler
Copy link
Contributor

@pydatawrangler pydatawrangler commented Dec 28, 2019 •
edited by ericmjl
Loading

Closes #81.

@ericmjl
Copy link
Owner

ericmjl commented Dec 28, 2019

Woohoo! Thanks @pydatawrangler!

@ericmjl
Copy link
Owner

ericmjl commented Dec 28, 2019

I think I just have to restart the failed CI runs, let me debug in a bit.

@ericmjl
Copy link
Owner

ericmjl commented Dec 28, 2019

It's only failing on py36, which I think should just be removed as a supported Python version for the repo anyways. Thanks, @pydatawrangler, I'm going to merge!

@ericmjl ericmjl merged commit 995130c into ericmjl:master Dec 28, 2019
@pydatawrangler pydatawrangler deleted the pydatawrangler-patch-1 branch December 28, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECDF function in util.py not returning right values
2 participants
@pydatawrangler @ericmjl