-
Notifications
You must be signed in to change notification settings - Fork 278
Make NBs 1&2 modular (WIP; do NOT merge) #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/ericmjl/bayesian-stats-modelling-tutorial/pull/77 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
a la this here: #72 (comment) I've modularized NB1. About to do same for NB2.
Currently naming new NBs 1-a, 1-b, 2-a, 2-b. Any thoughts on naming conventions, @ericmjl ? |
@ericmjl instructor NBs 1a/1b/2a/2b ready for review. See above comments for more context |
@hugobowne thanks a ton for doing this! Seeing what you've covered until NB 2b means I actually can get into thinking about the entire data-generating process earlier than I originally anticipated. This is great. The comments I have are mostly stylistic. The biggest one concerns headers: Would you be ok if I re-did the headers so that they reflect the logical hierarchy of each notebook more accurately? The hardest part for me navigating the notebooks were:
|
@ericmjl yes the more I think about it, the more enriching I think for everybody that we introduce thinking about the entire data-generating process as early as possible (and also ECDFs). I like to think of data-generating processes as first-class citizens of these lessons :) I'm fine with you making any stylistic edits. When you write:
are there any other comments? |
Thinking about it again, I don’t have any other stylistic edits for now. Ok, I will go into your branch and push up a few changes. Will loop back shortly. |
@hugobowne I've finished my stylistic changes. I hope you don't mind; doing these little tasks was great for me to go over the material with a fine-toothed comb. Having reviewed the material, these look like the teaching points, in my own words.
Beyond this foundation, everything else in the tutorial is nothing more than "describe data generating processes using probability distributions, and condition them on known data." |
Yep agreed wrt teaching points @ericmjl. A key point is the ability to match data to the stories that generate the data:
This is the key takeaway for me ^ |
@hugobowne just wanted to make sure this ball isn’t dropped - will you be making the student notebooks? If you need the personal time, do let me know, I can work on it. In fact, if I work on making it, the fine-toothed combing will help me go through the material again, so I’ll hopefully be more effective with the material you’ve created. Lmk what you think; if I don’t hear back by, say, evening ET July 4, I will go ahead and do the changes. |
@ericmjl Yep I was planning to do this over the weekend. I reckon it can mostly be done from the previous iteration of NBs pre-split, e.g. https://github.com/ericmjl/bayesian-stats-modelling-tutorial/blob/master/notebooks/01-Student-Probability_a_simulated_introduction.ipynb If you would like to do it from these, as you'll be teaching the tutorial & there may be personal decisions involved wrt tutorial cadence & style, I'm also okay with that. Let me know (I'm on Sydney time FYI: ET+14). |
Okie dokes, I'll take care of it - so that I can get familiar with the material. Have a good rest, Hugo - I hope I'll do the material justice 😄, especially with all the thought you've put into it. |
If there's anybody I'd trust to do the material justice, it's you @ericmjl. And I'm looking forward to hearing about your experience teaching it & how it resonates with you. I want to think more about teaching/thinking statistics via the story telling of data generating processes & your experience here will be invaluable. |
No description provided.