Repository navigation
docs(usage): refresh journal log section for v3.0.x behavior - #113
Merged
Merged
Conversation
The voice-notes section predated three shipped behaviors: the start press now preflights the whisper.cpp binary/model (#82), failures and empty recordings pop notifications (#81), and log.transcriber gained model_id for ggml provisioning (#112). Bring the fail-fast list, the notification paragraph, and the config-key list up to date.
…he boolean status The optional Hammerspoon menubar snippet matched ^recording against hs.execute's second return, a boolean — status:match(...) is a Lua error, so the dot could never turn ● during a recording. Match the output string (journal log --status prints "recording (...) — <wav>"). Found by a user copying the snippet verbatim.
Owner
Author
|
Added a second commit: the optional menubar-dot snippet had a real bug — it matched |
…on't source shell rc Found in live testing: with the repo resolved via JOURNAL_DIR exported in ~/.zshrc, the documented hotkey binding silently does nothing — Hammerspoon children never see the variable, journal exits 'not inside a journal repo', and the task's output is discarded. Thread the env through both the hotkey task and the menubar-dot poll.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USAGE.md's voice-notes section predated three shipped behaviors:
log.transcriber.model_id(fix(models): pull the whisper.cpp ggml model journal log actually needs #112, v3.0.1) — the config-key list omitted the new ggml provisioning key.Docs-only; caught during a post-v3.0.1 read-through of the section.